#51024: test: fixup autoupdater tests failures
Merged
Description of Change
- Autoupdater tests on mac were failing and then succeeding on retries, but that led to extensive time being spent to the point that sometimes the mac tests timeout, even after landing #50968, as evidenced in the 41-x-y backport here: #50974
This PR ups the timeouts for tests that were problematic and also updates spec/fixtures/auto-update/update-triple-stack/index.js to fix a race condition. Before this change that fixture was calling autoUpdater.checkForUpdates() every second - that 1 second gap caused a race condition where Squirrel's orphan-prune could delete a directory that a concurrent ShipIt download was still writing to, resulting in "The folder 'update-file' doesn't exist" errors.
Checklist
- I have built and tested this change
- I have filled out the PR description
- I have reviewed and verified the changes
-
npm testpasses - tests are changed or added
- PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.
Release Notes
Notes: none
Backports
Semver Impact
Major
Breaking changes
Minor
New features
Patch
Bug fixes
None
Docs, tests, etc.
Semantic Versioning helps users understand the impact of updates:
- Major (X.y.z): Breaking changes that may require code modifications
- Minor (x.Y.z): New features that maintain backward compatibility
- Patch (x.y.Z): Bug fixes that don't change the API
- None: Changes that don't affect using facing parts of Electron